Feature: Introduced Omnibar 1 #17023
Draft
+560
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x5bfa
force-pushed
the
5bfa/CQ-OmnibarIntroduction
branch
4 times, most recently
from
f93960a to
e1ee482
Compare
yaira2
reviewed
Apr 10, 2025
There was a problem hiding this comment.
It looks like there are some extra modifications to this file.
yaira2
reviewed
Apr 10, 2025
yaira2
reviewed
Apr 21, 2025
yaira2
reviewed
Apr 21, 2025
| if (e.IsRootItem) | ||
| { | ||
| // TODO: Populate a different flyout for the root item | ||
| e.Flyout.Items.Add(new MenuFlyoutHeaderItem() { Text = "Quick access" }); |
There was a problem hiding this comment.
Can you remove the placeholder menu? I would prefer not merging placeholder code.
yaira2
reviewed
Apr 21, 2025
| @@ -198,17 +206,56 @@ public bool IsSearchBoxVisible | |||
| } | |||
| } | |||
|
|
|||
| private string? _PathText; | |||
| public string? PathText | |||
| private string? _LegacySharedPathPaletteText; | |||
There was a problem hiding this comment.
Unless the property name is being reused, I would feel more comfortable if we kept the existing property names. Otherwise it will require additonal testing and a more thorough review.
yaira2
reviewed
Apr 21, 2025
| @@ -417,20 +417,20 @@ protected async void ShellPage_PathBoxItemDropped(object sender, PathBoxItemDrop | |||
|
|
|||
| protected async void ShellPage_AddressBarTextEntered(object sender, AddressBarTextEnteredEventArgs e) | |||
| { | |||
| await ToolbarViewModel.SetAddressBarSuggestionsAsync(e.AddressBarTextField, this); | |||
| await ToolbarViewModel.SetLegacyAddressBarSuggestionsAsync(e.AddressBarTextField, this); | |||
|
I found an issue where text entered into the address bar isn't cleared after removing the focus. The easiest way to test this is by removing the focus and then refocusing the address bar. |
0x5bfa
force-pushed
the
5bfa/CQ-OmnibarIntroduction
branch
from
8000bab to
0aeb079
Compare
0x5bfa
force-pushed
the
5bfa/CQ-OmnibarIntroduction
branch
from
0aeb079 to
e4ba94d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes