Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Add fixed # tasks per round. Closes space-meridian/roadmap#82 #385

Merged
merged 53 commits into from
Sep 19, 2024

Conversation

juliangruber
Copy link
Member

@juliangruber juliangruber commented Aug 2, 2024

Closes space-meridian/roadmap#82
Depends on filecoin-station/spark-stats#214

Alternatives considered:

  • Base task count on measurement count from previous round. This data doesn't exist in spark-stats yet. It should lead to better results though, than the currently used station-id count. @bajtos wdyt? Shall we give this a try and see if it behaves well enough? We went with this alternative

Questions:

  • Do we need to test this code path? Yes

TODO

  • Track in Graphana
    • measurements target for round
    • measurements count for round
    • total desired measurement count
    • actual measurement count
  • Write tests for scaling

@juliangruber
Copy link
Member Author

+   maxTasksPerNode: 2,
-   maxTasksPerNode: 15,

Using live data, this will decrease the job count by a lot. We might want to update the target job volume

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start!

Do we need to test this code path?

Yes, please. Otherwise, how can we verify that the algorithm works as intended?

api/lib/round-tracker.js Outdated Show resolved Hide resolved
api/lib/round-tracker.js Outdated Show resolved Hide resolved
api/lib/round-tracker.js Outdated Show resolved Hide resolved
api/lib/round-tracker.js Show resolved Hide resolved
api/lib/round-tracker.js Outdated Show resolved Hide resolved
api/lib/round-tracker.js Outdated Show resolved Hide resolved
@juliangruber juliangruber marked this pull request as ready for review September 13, 2024 10:42
@juliangruber juliangruber mentioned this pull request Sep 14, 2024
22 tasks
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think the proposed algorithm should work well 👍🏻

I'd like to improve a few minor details, PTAL below.

api/lib/round-tracker.js Outdated Show resolved Hide resolved
api/lib/round-tracker.js Outdated Show resolved Hide resolved
api/test/round-tracker.test.js Show resolved Hide resolved
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

api/lib/round-tracker.js Show resolved Hide resolved
@juliangruber
Copy link
Member Author

Thanks! Will ship tomorrow

@juliangruber juliangruber merged commit 5f7ab44 into main Sep 19, 2024
8 checks passed
@juliangruber juliangruber deleted the api/add/fixed-task-count-per-round branch September 19, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ done
Development

Successfully merging this pull request may close these issues.

SPARK/Meridian: Fixed # tasks per round
2 participants