feat(f3): f3-activation-contract integration #12861
Conversation
It has no chance of working on lite nodes right now Signed-off-by: Jakub Sztandera <[email protected]>
Includes shed tool for debuging, the tool could be re-written to use the the ContractManifestProvider. Integration of ContractManifestProvider into the existing manifest pipeline is missing. Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
feat/f3-activation-contract
branch
from
89275bd to
f41783e
Compare
Kubuxu
changed the title
Signed-off-by: Jakub Sztandera <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
Kubuxu
changed the title
github-actions
bot
dismissed
their stale review
PR title now matches the required format.
Kubuxu
changed the title
…essManifest` Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
| @@ -84,6 +88,7 @@ func NewConfig(nn dtypes.NetworkName) *Config { | |||
| PrioritizeStaticManifest: true, | |||
| DynamicManifestProvider: buildconstants.F3ManifestServerID, | |||
| AllowDynamicFinalize: false, | |||
| ContractPollInterval: 15 * time.Minute, | |||
There was a problem hiding this comment.
Thinking out-loud: would we ever want to change this in passive testing?
There was a problem hiding this comment.
we might, you are right for faster iteration speed
| } else if config.ContractAddress != "" { | ||
| primaryManifest, err = NewContractManifestProvider(mctx, config, stateCaller) | ||
| } | ||
| if err != nil { |
There was a problem hiding this comment.
Would be good to have an info log somewhere that logs whether the primary manifest ended up being Contract or Static.
| address string | ||
| networkName gpbft.NetworkName | ||
| stateCaller StateCaller | ||
| PollInterval time.Duration |
There was a problem hiding this comment.
It was from before I had the poll interval in the config to be used by the shed utility
| if len(cmp.address) == 0 { | ||
| // close the channel so fusing provider knows we have nothing | ||
| close(cmp.manifestChanges) | ||
| return nil |
| return &m, nil | ||
| } | ||
|
|
||
| func parseContractReturn(retBytes []byte) (uint64, []byte, error) { |
There was a problem hiding this comment.
non blocker: I would move this function to be after the one that first calls it (i.e., after fetchManifest).
|
|
||
| Flags: []cli.Flag{ | ||
| &cli.StringFlag{ | ||
| Name: "contract", |
There was a problem hiding this comment.
it is lotus-shed but sure :P
| } | ||
|
|
||
| var f3CheckActivationRaw = &cli.Command{ | ||
| Name: "check-activation-raw", |
There was a problem hiding this comment.
description for these commands would be nice
| return fmt.Errorf("bootstrap epoch does not match: %d != %d", m.BootstrapEpoch, activationEpoch) | ||
| } | ||
| io.Copy(os.Stdout, flate.NewReader(bytes.NewReader(compressedManifest))) | ||
| fmt.Printf("\n") |
There was a problem hiding this comment.
| fmt.Printf("\n") | |
| fmt.Println() |
| if m.BootstrapEpoch < 0 || uint64(m.BootstrapEpoch) != activationEpoch { | ||
| return fmt.Errorf("bootstrap epoch does not match: %d != %d", m.BootstrapEpoch, activationEpoch) | ||
| } | ||
| io.Copy(os.Stdout, flate.NewReader(bytes.NewReader(compressedManifest))) |
There was a problem hiding this comment.
Explicitly ignore the error?
| io.Copy(os.Stdout, flate.NewReader(bytes.NewReader(compressedManifest))) | |
| _, _ = io.Copy(os.Stdout, flate.NewReader(bytes.NewReader(compressedManifest))) |
Includes shed tool for debuging, the tool could be re-written to use the
the ContractManifestProvider.
Integration of ContractManifestProvider into the existing manifest
pipeline is missing.