added benchmarks for G_T #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmx
requested changes
Jul 15, 2024
There was a problem hiding this comment.
Thanks, this looks good! Running the benchmarks need a nightly Rust, so the 1.56.1 isn't a problem there. What were you issues? I'd prefer if we keep the version in the Cargo.toml and the rust-toolchain file.
Please also run cargo fmt for consistent formatting.
|
I now also see an error locally on master. I'll have a look (it should be independent of this PR). |
|
CI should be fixed now, could you please rebase your change? |
|
Rebased and formatted with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some missing benchmarks for$\mathbb{G}_T$ operations.
Note: The
rust_toolchainfile and the hardcoded version inCargo.tomlcaused problems for me. However, I can revert those changes if need be.