Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding hides explorer icons feature also vscode did the tasks.json mo… #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alfonsocv12
Copy link

…difications

Copy link
Member

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola,

Could you please elaborate on what your changes are doing? Your PR's title is rather ambiguous, and I'm afraid I'm not familiar enough with VSCode to understand at a glance what your code is doing.

"commands": [
{
"command": "file-icons-colourless.hidesExplorerArrows",
"title": "%command.hidesExplorerArrows%"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally, and received the following error:

Command '%command.hidesExplorerArrows%' resulted in an error (command 'file-icons.hidesExplorerArrows' not found)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try to replicate that error

Comment on lines 1 to 30
// Available variables which can be used inside of strings.
// ${workspaceRoot}: the root folder of the team
// ${file}: the current opened file
// ${fileBasename}: the current opened file's basename
// ${fileDirname}: the current opened file's dirname
// ${fileExtname}: the current opened file's extension
// ${cwd}: the current working directory of the spawned process

// A task runner that calls a custom npm script that compiles the extension.
{
"version": "0.1.0",

// we want to run npm
"command": "npm",

// the command is a shell script
"isShellCommand": true,

// show the output window only if unrecognized errors occur.
"showOutput": "silent",

// we run the custom script "compile" as defined in package.json
"args": ["run", "compile", "--loglevel", "silent"],

// The tsc compiler is started in watching mode
"isWatching": true,

// use the standard tsc in watch mode problem matcher to find compile problems in the output.
"problemMatcher": "$tsc-watch"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this file (tasks.json.old) do?

@alfonsocv12
Copy link
Author

Hola, qué tal?,

Sorry for my delay response the notification got lost. Well the feature that I'm trying to implement is to add the option to hide this arrows from the explorer.

Screen Shot 2022-08-26 at 5 52 17 PM

I believe all of that is just the IDE settings for my personal setup I added the file to .gitignore because is not require

@alfonsocv12
Copy link
Author

35470491-ab820dba-034a-11e8-97e3-1564d153ddb8

to something like this It seems like the API is broken from this other issue I was trying to test this again on another computer an is also not working.

microsoft/vscode#42238

Let me see if I can fix the issue in the weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants