Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Custom Auth Guard For The Export And The Import Classes. #15404

Conversation

Abdelhammied
Copy link

Add Getting user by the panel guard for different guards and assert the filament function exists for panel usage

Description

Add Getting user by the panel guard for different guards and assert the filament function exists for panel usage.
Because the code was written to get the default guard only, the added code can check if filament exists so if the import and export actions have been used alone or with filament both cases will be handled

Visual changes

image
image

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@Abdelhammied Abdelhammied mentioned this pull request Jan 22, 2025
3 tasks
@danharrin
Copy link
Member

As I described in the other PR, a similar feature has already been built for v4 but it's not the same API is this. I am not going to merge an API like this into v3 that will then just be deprecated as it creates maintenance work for people.

In this situation, I would suggest you extend ImportAction and ExportAction in your own app and override the methods you need to customize the guard.

@danharrin danharrin closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants