Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes mounting of arguments on infolist actions #15359

Draft
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

MACscr
Copy link
Contributor

@MACscr MACscr commented Jan 16, 2025

Description

This PR enhances the Infolist action handling system by adding support for passing arguments to mounted actions. It also improves the action unmounting process by consolidating the cleanup of related data structures.

Special thanks to @archilex who helped me troubleshoot the bug and find a solution.

Key changes:

  • Added argument support when mounting Infolist actions
  • Introduced a new mountedInfolistActionsArguments property to store action arguments
  • Consolidated action unmounting logic into a new popMountedInfolistAction method
  • Updated getMountedInfolistAction to properly pass stored arguments to actions
  • Fixed array cleanup during action unmounting to prevent data inconsistencies

Functional changes

  • Code style has been fixed by running the composer cs command
  • Changes have been tested to not break existing functionality
  • Documentation is up-to-date

Benefits

  • Enables passing contextual data to Infolist actions
  • Improves code maintainability by centralizing unmounting logic
  • Ensures proper cleanup of all related data structures when unmounting actions

@MACscr MACscr marked this pull request as draft January 16, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant