Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fi: Sub Navigation Icon Fallback #15345

Closed
wants to merge 1 commit into from

Conversation

FortuneV13
Copy link
Contributor

@FortuneV13 FortuneV13 commented Jan 14, 2025

When using sub-navigation, you can usually omit a navigation icon, and a dot with a line will be displayed. However, when combining Pages with a ManageRelatedRecords page, omitting the icon from ManageRelatedRecords defaults to a rectangular icon, disrupting the consistent appearance. For clarity it seems that ManageRelatedRecords pages in the Sub Navigation falls back to the rectangle icon.

Before:
Screenshot 2025-01-14 at 21 43 54

After:
Screenshot 2025-01-14 at 21 43 40

@FortuneV13 FortuneV13 changed the title Update ManageRelatedRecords.php Fix Naviation Icon Fallback Jan 14, 2025
@FortuneV13 FortuneV13 changed the title Fix Naviation Icon Fallback Fi: Sub Naviation Icon Fallback Jan 15, 2025
@FortuneV13 FortuneV13 changed the title Fi: Sub Naviation Icon Fallback Fi: Sub Navigation Icon Fallback Jan 15, 2025
@FortuneV13 FortuneV13 closed this Jan 15, 2025
@FortuneV13 FortuneV13 reopened this Jan 16, 2025
@danharrin
Copy link
Member

This is consistent with the edit/view pages which also have icons by default, you can override the method to return null if you want to remove the icon.

@danharrin danharrin closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants