Panels navigation documentation #15109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix - if you have `dark` theme set on macbook - light screenshots would also be dark.
danharrin
requested changes
Dec 31, 2024
| @@ -376,6 +402,8 @@ public function panel(Panel $panel): Panel | |||
| } | |||
| ``` | |||
|
|
|||
| <AutoScreenshot name="panels/navigation/custom-items" alt="Register Custom Navigation Items" version="3.x" /> | |||
There was a problem hiding this comment.
Please do not use Title Case for the alt text within screenshots, please check this is consistent with existing screenshots :)
There was a problem hiding this comment.
Heh, sorry about that! Too used to Title Case :)
There was a problem hiding this comment.
Maybe we could use a badge for the sort number instead of putting it in the label?
There was a problem hiding this comment.
Maybe the example here could be an -o- cog and a -s- cog?
docs-assets/app/routes/web.php
Outdated
| Route::get('layout', InfolistsLayoutDemo::class); | ||
| }); | ||
|
|
||
| Route::group(['prefix' => 'panels'], function () { |
There was a problem hiding this comment.
Can we use Route::prefix() here please for better static analysis
There was a problem hiding this comment.
Can we use the same empty view across multiple pages instead of duplicating?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentation updates for Panels -> Navigation.
This includes a few non-documentation updates:
panels/navigation...prefix (Commit)Darkpreference would not generateLightscreenshots (Commit)And, of course, added images for:
In one case, I had to split the text better to visualize the difference (Collapsible vs. not group).
Other than that - let me know if this is okay :)
Visual changes
None
Functional changes
composer cscommand.