Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar doesn't account for dynamic viewport height #10915

Open
nicko170 opened this issue Jan 18, 2024 · 2 comments
Open

Sidebar doesn't account for dynamic viewport height #10915

nicko170 opened this issue Jan 18, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@nicko170
Copy link
Contributor

nicko170 commented Jan 18, 2024

Package

filament/filament

Package Version

v3.2.5

Laravel Version

v10.41.0

Livewire Version

v3.3.5

PHP Version

8.3.0

Problem description

hey @zepfietje as discussed in Discord, menu scrolling in Chrome and Safari on iOS does not work. I haven't tested Android. If there are more than say 10 items, you cannot get to the bottom ones in the list as there isn't enough padding on the bottom. See attached video, and reproduction repository.

Originally thought this was minimal theme doing it - but it's happening in core too

rpreplay-final1705617942_TRuDOjkH.mp4

Expected behavior

The items at the botton of the menu stay on screen and can be clicked whilst using the menu on mobile devices.

Steps to reproduce

Load the dashboard with a large (say 30) number of items, and try scrolling in chrome or safari on an ios device, not in the chrome device simulator as that doesn't match the behaviour of the on device app headers.

Reproduction repository

https://github.com/nicko170/filament-demo

Relevant log output

No response

Donate 💰 to fund this issue

  • You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
  • 100% of the funding will be distributed between the Filament core team to run all aspects of the project.
  • Thank you in advance for helping us make maintenance sustainable!
Fund with Polar
@nicko170 nicko170 added bug Something isn't working low priority unconfirmed labels Jan 18, 2024
@github-project-automation github-project-automation bot moved this to Todo in Roadmap Jan 18, 2024
@danharrin danharrin added this to the v3 milestone Jan 19, 2024
@ziming
Copy link
Contributor

ziming commented Jan 24, 2024

can confirm this is happening on iPhone

scrolling also have issue on table slide over & modal on iPhone safari and chrome. So people can't scroll down when they click on an action on the table row & a slideover & modal shows up

@zepfietje
Copy link
Member

Just opened an issue for that when I noticed it myself: #11034. @ziming

@zepfietje zepfietje changed the title Large menus on mobile devices do not work correctly Sidebar doesn't account for dynamic viewport height Jan 31, 2024
@polar-sh polar-sh bot added the Fund label Jun 3, 2024
@danharrin danharrin removed the fund label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

4 participants