Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiTenancy menu to limit the no of tenants shown with filter text widget #11771

Closed
declum opened this issue Mar 8, 2024 · 8 comments · Fixed by #11857
Closed

MultiTenancy menu to limit the no of tenants shown with filter text widget #11771

declum opened this issue Mar 8, 2024 · 8 comments · Fixed by #11857
Assignees
Milestone

Comments

@declum
Copy link
Contributor

declum commented Mar 8, 2024

Package

filament/filament

Package Version

v3.2

Laravel Version

v11.0

Livewire Version

No response

PHP Version

8.2

Problem description

When user is part of many teams, and we enable multi tenancy, the menu appears too big which requires scrolling to find. (we have a bug for this scroll in mobile view in issue 7830)

Expected behavior

We want the menu to limit the teams/tenant shown, and allow filters to search for team.

Steps to reproduce

git clone https://github.com/declum/example-repo
cd example-repo
mv .env.example .env
php artisan migrate --seed <- This will also create [[email protected]](mailto:[email protected]) user with 100 teams (password is "password")
php artisan serve

Reproduction repository

https://github.com/declum/example-repo

Relevant log output

No response

@declum declum added bug Something isn't working low priority unconfirmed labels Mar 8, 2024
@github-project-automation github-project-automation bot moved this to Todo in Roadmap Mar 8, 2024
@danharrin danharrin added this to the v3 milestone Mar 10, 2024
@danharrin
Copy link
Member

This just sounds like a feature request, can you take a screenshot of the visual bug with the menu getting cut off?

@declum
Copy link
Contributor Author

declum commented Mar 11, 2024

1
2
Attached.

Menu doesnt scroll.

Here two things.

1 is a bug where the menu is not scrolling
2 is a feature request if we can limit the shown items, and allow the search option to pick the team without involving scrolling.

@danharrin
Copy link
Member

FYI - the issue will be closed when the bug is fixed, feature requests belong in Discussions or you can PR it yourself.

@zepfietje
Copy link
Member

Isn't this just a duplicate of #10915?

@danharrin
Copy link
Member

@zepfietje similar, but this one will be closed when we make the dropdown scrollable. We will use the "size" feature of Floating UI, Adam is going to handle it when he has time.

@awcodes
Copy link
Contributor

awcodes commented Mar 12, 2024

Should I worry about the searchable or just the scrollable?

@awcodes
Copy link
Contributor

awcodes commented Mar 12, 2024

I can see this applying to other areas like filters too.

@danharrin
Copy link
Member

Just scrollable for now, the searchable is just a feature request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants