fix: config props

src/lib/PlayerMedia.svelte

@@ -7,7 +7,7 @@
 		Player,
 		PlayerRef,
 		PlayerDispatcher,
-		PlayerConfigObject,
+		PlayerConfigProps,
 		PlayerGetPlayerKey,
 		PlayerInternalPlayer
 	} from './players/types';
@@ -27,7 +27,7 @@
 	export let playsinline: boolean;
 	export let pip: boolean;
 	export let stopOnUnmount: boolean;
-	export let config: PlayerConfigObject;
+	export let config: PlayerConfigProps;
 
 	export let progressFrequency: number | undefined = undefined;
 	export let disableDeferredLoading: boolean | undefined = undefined;

src/lib/SveltePlayer.svelte

@@ -37,7 +37,7 @@
 	import type {
 		PlayerUrl,
 		PlayerConfig,
-		PlayerConfigKey,
+		PlayerConfigProps,
 		PlayerGetPlayerKey,
 		PlayerInternalPlayer
 	} from './players/types';
@@ -128,9 +128,12 @@
 		dispatch('ready');
 	}
 
-	function getConfig<T extends PlayerConfigKey>(configUrl: PlayerUrl, configKey: T) {
-		const memoized = memoize<(url: typeof configUrl, key: T) => PlayerConfig[T]>((_, key) => {
-			return merge<PlayerConfig[T]>(defaultConfig[key] || {}, config[key] || {});
+	function getConfig<TUrl extends PlayerUrl, TKey extends string>(
+		configUrl: TUrl,
+		configKey: TKey
+	) {
+		const memoized = memoize<(url: TUrl, key: TKey) => PlayerConfigProps>((_, key) => {
+			return merge<PlayerConfigProps>(defaultConfig[key] || {}, config[key] || {});
 		});
 
 		return memoized(configUrl, configKey);

src/lib/players/types.ts

@@ -30,7 +30,6 @@ import type {
 	FileErrorSDKGlobal,
 	FileInternalPlayer
 } from './file.types';
-import type { NotImplementedConfig } from './notimplemented.types';
 
 export type PlayerInstance =
 	| YTPlayer
@@ -52,20 +51,32 @@ export type PlayerInternalPlayer = Omit<FileInternalPlayer, 'player'> & {
 
 export type PlayerGetPlayerKey = keyof PlayerInternalPlayer;
 
-export type PlayerConfig = {
+export type PlayerConfigObject = {
 	youtube: YouTubeConfig;
 	soundcloud: SoundCloudConfig;
 	vimeo: ViemoConfig;
 	facebook: FacebookConfig;
-	streamable: undefined;
 	wistia: WistiaConfig;
 	twitch: TwitchConfig;
 	dailymotion: DailyMotionConfig;
 	mixcloud: MixcloudConfig;
 	vidyard: VidyardConfig;
-	kaltura: undefined;
 	file: FileConfig;
-	'not-implemented': NotImplementedConfig;
+};
+
+export type PlayerConfigKey = keyof PlayerConfigObject;
+
+export type PlayerConfigValue = PlayerConfigObject[PlayerConfigKey];
+
+/* eslint-disable-next-line @typescript-eslint/ban-types
+-- This is hacky trick to preserve auto-complete the possible union string
+ meanwhile still able to assign string value outside the unioin string  */
+export type PlayerKey = PlayerConfigKey | (string & {});
+
+export type PlayerConfig = {
+	[Property in PlayerKey]: Property extends PlayerConfigKey
+		? PlayerConfigObject[Property]
+		: unknown;
 };
 
 export type PlayerUrl = string | YouTubeUrl | FileUrl;
@@ -112,9 +123,7 @@ export type PlayerDispatcher = {
 	loaded: undefined;
 };
 
-export type PlayerConfigKey = keyof PlayerConfig;
-
-export type PlayerConfigObject = PlayerConfig[PlayerConfigKey];
+export type PlayerConfigProps = RecursivePartial<PlayerConfigValue>;
 
 export type PlayerProps = {
 	url: PlayerUrl;
@@ -132,7 +141,7 @@ export type PlayerProps = {
 	pip: boolean;
 	stopOnUnmount: boolean;
 	previewTabIndex: number;
-	config: RecursivePartial<PlayerConfigObject>;
+	config: PlayerConfigProps;
 	oEmbedUrl: string;
 	display: string;
 };
@@ -160,7 +169,7 @@ export type PlayerRef = {
 export type PlayerComponent = Constructor<SvelteComponent<Partial<PlayerProps>> & PlayerRef>;
 
 export type Player = {
-	key: PlayerConfigKey;
+	key: PlayerKey;
 	name: string;
 	loopOnEnded?: boolean;
 	forceLoad?: boolean;

src/lib/players/utility.types.ts

@@ -16,12 +16,12 @@ export type Constructor<T> = new (...args: any[]) => T;
 
 export type Prettify<T> = {
 	[K in keyof T]: T[K];
-	/* eslint-disable-next-line @typescript-eslint/ban-types -- TODO: Comment this*/
+	/* eslint-disable-next-line @typescript-eslint/ban-types -- this is fine*/
 } & {};
 
 // https://stackoverflow.com/a/70428144/12976234
 export type PickMatching<T, V> = { [K in keyof T as T[K] extends V ? K : never]: T[K] };
-/* eslint-disable-next-line @typescript-eslint/ban-types -- TODO: Comment this*/
+/* eslint-disable-next-line @typescript-eslint/ban-types -- this is fine*/
 export type ObjectMethods<T> = PickMatching<T, Function>;
 
 /* eslint-disable-next-line @typescript-eslint/no-explicit-any -- this is fine*/

src/lib/props.ts

@@ -11,7 +11,6 @@ export const defaultConfig: PlayerConfig = {
 			show_playcount: false
 		}
 	},
-	streamable: undefined,
 	youtube: {
 		playerVars: {
 			playsinline: 1,
@@ -43,7 +42,6 @@ export const defaultConfig: PlayerConfig = {
 		},
 		title: null
 	},
-	kaltura: undefined,
 	file: {
 		attributes: {},
 		tracks: [],
@@ -74,6 +72,5 @@ export const defaultConfig: PlayerConfig = {
 	},
 	vidyard: {
 		options: {}
-	},
-	'not-implemented': {}
+	}
 };

src/test/players/DailyMotion.test.ts

@@ -63,7 +63,7 @@ test('load()', async function (t) {
 	return Promise.resolve();
 });
 
-// TODO: Add test for this, this behaciour cannot
+// TODO: Add test for this, this behaviour cannot
 // be tested yet because we can't set container
 // programmatically
 test('load() - no container', async function (t) {