Fixes #274 and #230 #276
Open
Fixes #274 and #230 #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have built this patch locally. Started testing on 10.12.5 with MBP + 3 external displays. Appears to fix the issues I was having with #274 so far. I will report back if I encounter issues in the next few days. |
|
Thanks a lot. I do not have a way to test it now, @rca - could you please have a look at it and if it works create a new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on 10.12.6 only with mbp and one external display.
Not sure if
getRunningAppFocusedWindowInfomight cause any memory leaks.I also got the app unresponsive one time, not sure if this is caused by the change, will keep looking closely on it.