Skip to content

Commit

Permalink
Add node 20 support
Browse files Browse the repository at this point in the history
  • Loading branch information
jfirebaugh committed Jan 25, 2024
1 parent 27d338d commit 084be25
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 10 deletions.
16 changes: 10 additions & 6 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
name: "Linux Tests"
strategy:
matrix:
node: [14, 16, 18]
node: [18, 20]
runs-on: ubuntu-latest
container: ubuntu:20.04
steps:
Expand All @@ -37,10 +37,10 @@ jobs:
git config --global user.name "John Doe"
git config --global user.email [email protected]
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: Use Node.js
uses: actions/setup-node@v2
uses: actions/setup-node@v4
env:
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
with:
Expand Down Expand Up @@ -87,7 +87,7 @@ jobs:
name: "macOS Tests"
strategy:
matrix:
node: [14, 16, 18]
node: [18, 20]
runs-on: macOS-12
# This is mostly the same as the Linux steps, waiting for anchor support
# https://github.com/actions/runner/issues/1182
Expand All @@ -103,16 +103,20 @@ jobs:
git config --global user.name "John Doe"
git config --global user.email [email protected]
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: Use Node.js
uses: actions/setup-node@v2
uses: actions/setup-node@v4
env:
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
with:
node-version: ${{ matrix.node }}
check-latest: true

# https://github.com/nodejs/node-gyp/issues/2869
- name: Install Python utilities
run: python3 -m pip install setuptools

- name: Install
env:
CC: clang
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 084be25

Please sign in to comment.