Fix missing output when no release has been made #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 05ed406 added "set -o pipefail" in assets/check, but this creates a tiny side effect: When no revisions exist yet, "grep -i 'deployed'" returns 1, and with pipefail enabled, the whole pipe returns 1. At this point, the script immediately exits (due to "set -e"), and the output in line 57 will never happen, confusing the user.
|
FYI, the problem was initially discussed here: https://fielmann.slack.com/archives/C93PX77RU/p1614791520135100?thread_ts=1614789611.133000&cid=C93PX77RU This Screenshot shows the behavior prior to this PR:
|
|
Yes, that sounds right and looks good. |
|
@lanixxfielmann Could you merge this (I don't have permission for it)? It's been a while since I opened the PR, and I think this fix could help others. Especially when starting out with this resource and setting up a new pipeline. |
|
Oh, just noticing: Or should I update the VERSION-file, too? Not sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 05ed406 added "set -o pipefail" in assets/check, but this creates
a tiny side effect:
When no revisions exist yet, "grep -i 'deployed'" returns 1,
and with pipefail enabled, the whole pipe returns 1.
At this point, the script immediately exits (due to "set -e"), and the
output in line 57 will never happen, confusing the user.