Adds __map__ functionality #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile types -- easier to just cast back to the native underlying str type
Issue 296
Force change to not check read write privs Signed-off-by: Nicholas Cilfone <[email protected]>
Removed permissions tests as it now defaults to false on checking r+w since this can break things on AWS Signed-off-by: Nicholas Cilfone <[email protected]>
|
Merged in fix for #296 - fixed tests to remove the r+w check since default is now changed to not check privs |
|
@mmalouane This is the new PR that will cover #296 as well. Can you review and merge and release to help unblock this: #297 (comment) |
Pull Request Test Coverage Report for Build 6746688429
💛 - Coveralls |
|
@mmalouane Ignore the failing build on 3.6 since we are deprecating support -- I think that one is stuck somehow. You should be able to force the merge as along as all the other tests pass |
mmalouane
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds map functionality as another post instantiation hook option. This allows you to directly map spock configs to object creation etc. automatically upon creation. Additional docs and tests
Checklist