Skip to content
This repository was archived by the owner on Feb 8, 2018. It is now read-only.

Node 0.6 updates #30

Closed
wants to merge 4 commits into from
Closed

Node 0.6 updates #30

wants to merge 4 commits into from

Conversation

michaeltwofish
Copy link
Contributor

Incorporates #29 and #29.

See
https://github.com/joyent/node/wiki/API-changes-between-v0.4-and-v0.6.

  • Don't use require.paths, as it's no longer mutable.
  • Don't use process.binding('stdio'), as it was private and has been removed.

Note that no effort has been made to address #24, this is just to get up
and running with node 0.6.

In node 0.4.4 Script was changed to NodeScript to avoid conflict with
V8's Script class. See
nodejs/node-v0.x-archive@75db199
Node's querystring.stringify doesn't support nested objects, so nested
requestData was silently dropped. The qs module provides nested object support.
See
https://github.com/joyent/node/wiki/API-changes-between-v0.4-and-v0.6.

* Don't use require.paths, as it's no longer mutable.
* Don't use process.binding('stdio'), as it was private and has been removed.

Note that no effort has been made to address #24, this is just to get up
and running with node 0.6.
@michaeltwofish
Copy link
Contributor Author

There's still something a bit funky with the readline stuff with this pull request.

@michaeltwofish
Copy link
Contributor Author

Some possible responses:

  • We'd like this addressed in conjunction with Clean up the mess #24.
  • We'd like to maintain backward compatibility with node 0.4.
  • We'd like some tests with this.
  • Your code is awful, and we wouldn't consider including it.
  • The pull request is a mess, fix it up and we'll consider it.
  • We won't consider this pull request until the readline stuff is perfect.
  • We're open to bribery in the form of expensive scotch.

@michaeltwofish
Copy link
Contributor Author

Or, you could just commit it :)

Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant