Fix out of bounds indexes when retrieving camera matrix for rectified images #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… images Co-authored-by: Sandip Das <[email protected]>
|
@Mergifyio backport iron humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
… images (#47) * Fix out of bounds indexes when retrieving camera matrix for rectified images Co-authored-by: Sandip Das <[email protected]> * Add image_is_rectified parameter to example yaml config --------- Co-authored-by: Sandip Das <[email protected]> (cherry picked from commit 988501b)
mergify bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
… images (#47) * Fix out of bounds indexes when retrieving camera matrix for rectified images Co-authored-by: Sandip Das <[email protected]> * Add image_is_rectified parameter to example yaml config --------- Co-authored-by: Sandip Das <[email protected]> (cherry picked from commit 988501b)
bjsowa
added a commit
that referenced
this pull request
Jun 4, 2024
… images (#47) (#48) * Fix out of bounds indexes when retrieving camera matrix for rectified images Co-authored-by: Sandip Das <[email protected]> * Add image_is_rectified parameter to example yaml config --------- Co-authored-by: Sandip Das <[email protected]> (cherry picked from commit 988501b) Co-authored-by: Błażej Sowa <[email protected]>
bjsowa
added a commit
that referenced
this pull request
Jun 4, 2024
… images (#47) (#49) * Fix out of bounds indexes when retrieving camera matrix for rectified images Co-authored-by: Sandip Das <[email protected]> * Add image_is_rectified parameter to example yaml config --------- Co-authored-by: Sandip Das <[email protected]> (cherry picked from commit 988501b) Co-authored-by: Błażej Sowa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #46 I noticed that the ROS2 port tries to fit 3x4 Projection matrix into 3x3 cv::Mat which results in out of bounds indexes. This did not raise an exception as OpenCv does array range checking only in Debug mode.
This PR makes the camera matrix retrieval for rectified images work the same as in ROS1 version after applying fix from @real-Sandip-Das
I also added
image_is_rectifiedparameter, which was missing for a long time, to the example yaml file.