Converters for Austria and Brazil #49
Conversation
| @@ -0,0 +1,140 @@ | |||
| # TEMPLATE FOR A FIBOA CONVERTER | |||
There was a problem hiding this comment.
I propose to rename to fs_at.py
| @@ -0,0 +1,136 @@ | |||
| # TEMPLATE FOR A FIBOA CONVERTER | |||
There was a problem hiding this comment.
I propose to rename to fs_br.py
| # Title of the collection | ||
| TITLE = "Field boundaries for Austria (Fieldscapes)" | ||
| # Description of the collection. Can be multiline and include CommonMark. | ||
| DESCRIPTION = """ The dataset contains field boundaries for the Austria.""" |
There was a problem hiding this comment.
| DESCRIPTION = """ The dataset contains field boundaries for the Austria.""" | |
| DESCRIPTION = "The dataset contains field boundaries for the Austria." |
There was a problem hiding this comment.
Why does the template contain three apostrophes, if one is desired here? Is it that three lets you do multiline? But multiline isn't needed for this one?
There was a problem hiding this comment.
Yes, """ is multiline, " is single line.
I provided """ as default to make like simpler for implementors as I had hoped for a bit longer, usually multiline descriptions.
| # Add columns with constant values. | ||
| # The key is the column name, the value is a constant value that's used for all rows. | ||
| ADD_COLUMNS = { | ||
| "determination_datetime": "2021-01-01T00:00:00Z" |
There was a problem hiding this comment.
Where does this information come from? If it's unknown, better remove the line.
There was a problem hiding this comment.
I did a similar thing in the France dataset. These datasets from the government are released once a year, and so all the fields in it are clearly for that year. But they don't have any more specificity on a per field level.
Putting in the first of the year is obviously the safest. I think with France I saw some 'release date', so I used that.
It does seem very useful to know that it's from that year, so I lean towards including it in some way, like is done here.
There was a problem hiding this comment.
Yes, but yesterday we realized that people put things like the upload date ofthe source data there. That's not the determination time.
We should start on the timestamps extension now, otherwise determination_datetime ends up being just whatever time the creator finds/has available.
As I've asked before in the meeting notes doc: Do you organize the meeting for the timestamps extension discussion or shall someone else take the lead? I can also organize it, but it sounded like you'd lead it, so don't want to interfere with you ;-) @cholmes
There was a problem hiding this comment.
Yes, but yesterday we realized that people put things like the upload date ofthe source data there. That's not the determination time.
Agreed, that's not good.
Do you organize the meeting for the timestamps extension discussion or shall someone else take the lead? I can also organize it, but it sounded like you'd lead it, so don't want to interfere with you ;-) @cholmes
Yeah, sorry I've been negligent. I just sent out one on the deforestation regulation stuff. Will do a smaller timestamps / core one now.
| # Add columns with constant values. | ||
| # The key is the column name, the value is a constant value that's used for all rows. | ||
| ADD_COLUMNS = { | ||
| "determination_datetime": "2020-01-01T00:00:00Z" |
There was a problem hiding this comment.
Where does this information come from?`If it's unknown, better remove the line.
|
|
||
| # Schemas for the fields that are not defined in fiboa | ||
| # Keys must be the values from the COLUMNS dict, not the keys | ||
| MISSING_SCHEMAS = { |
There was a problem hiding this comment.
schemas missing for properties that are not defined by fiboa core spec.
| # Title of the collection | ||
| TITLE = "Field boundaries for Brazil (Fieldscapes)" | ||
| # Description of the collection. Can be multiline and include CommonMark. | ||
| DESCRIPTION = """ The dataset contains field boundaries for the Brazil.""" |
There was a problem hiding this comment.
| DESCRIPTION = """ The dataset contains field boundaries for the Brazil.""" | |
| DESCRIPTION = "The dataset contains field boundaries for the Brazil." |
|
Please rebase the PR to the latest CLI version, including renaming the URI constant to SOURCES and renaming the parameter cache_file to cache. I tried to push it upstream, but you didn't permit changes to this PR so you need to do these changes yourself. Thanks. |
|
@aninda-ghosh What's the difference to the existing converter for Austria ( |
Added converters for