-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI tests for Windows with Appveyor #378
Open
stdevPavelmc
wants to merge
44
commits into
fibercrypto:develop
Choose a base branch
from
stdevPavelmc:stdevPavelmc_t342_appveyor_ci_for_windows
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add CI tests for Windows with Appveyor #378
stdevPavelmc
wants to merge
44
commits into
fibercrypto:develop
from
stdevPavelmc:stdevPavelmc_t342_appveyor_ci_for_windows
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on that repo for windows compilation
…ectory: as a directory or it will fail on the MSYS2 shell
…tion of a symlink, in windows works strange
… env level, add names to the build matrix
…on3 but Linux must not as submodules are build against ptython2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #342
Changes:
Does this change need to mentioned in CHANGELOG.md?
yes
Requires testing
yes, it's about testing
Comments about testing , should you have some
So far to support it we have to add support on skywallet-protob see fibercrypto/skywallet-protob#82 maybe we will need to tweak some other dependency.