Add new toolchain release 10.3-2021.07 #26
Conversation
| @@ -14,7 +14,7 @@ function urlExt(s: string): string { | |||
| const components = u.path?.split('/') | |||
| if (components && components?.length > 0) { | |||
| const last = components[components?.length - 1] | |||
| const dot = last.indexOf('.') | |||
| const dot = last.lastIndexOf('.') | |||
There was a problem hiding this comment.
As the version format contains dots (.) urlExt() was returning .3-2021.07.tar.bz2 as the extension. So with this change we only look at the last part of the extension.
This also required a change in the switch case below to match .bz2 instead of .tar.bz2.
| switch (platform) { | ||
| case 'darwin': | ||
| osName = 'mac' | ||
| archOs = 'mac' | ||
| ext = 'tar.bz2' | ||
| macExtraOS = '-10.14.6' |
There was a problem hiding this comment.
The macOS download now contains the OS version (I assume used to build GCC) in the filename, so ${MAC_EXTRA_OS} has been added to the URL to be replaced.
| const parts = version.split('-') | ||
| if (parts.length !== 3) { |
There was a problem hiding this comment.
As the version string now only contains two - this needed to be updated as well.
It looks to me that thiss was basically checking if the version inputted by the user was valid, so I've replaced it with a check for the key in the versions object: if (!versions.hasOwnProperty(version))
|
Btw, even though the CI hasn't started in the PR yet (needs approval first), the tests do pass on my fork: |
|
Hola @fiam, Just wondering if you can review this PR, or in the meantime approve the workflow so that the CI can run? Thanks! |
|
If anybody arrives here looking for the latest release I've added it to my fork, together with a few more features: https://github.com/carlosperate/arm-none-eabi-gcc-action |
As the version format has changed this required some minor tweaks to the code as well.
I'll add notes to the PR.