For build date use Go-compatible RFC3339 date format, fixes update check
#259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerrit91
changed the title
update check
majst01
approved these changes
Sep 13, 2023
This was referenced Sep 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, GNU date produces a date with the
--rfc-3339=secondsthat Golang cannot parse with it's RFC3339 format definition.Instead we need to use the
--iso-8601=secondsflag, which is at least parsable with Go.Here I demonstrate the behavior: https://go.dev/play/p/FSXBzJcqpUA
There is also a good blog article talking about this issue and where it comes from: https://utcc.utoronto.ca/~cks/space/blog/unix/GNUDateAndRFC3339
Other repositories where we need to apply this change to:
update checkis now broken)The bug was introduced in this commit: https://github.com/fi-ts/cloudctl/pull/248/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
Closes #258.