FI-2332 Bump Ruby to 3 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
360dgries
changed the title
360dgries
force-pushed
the
FI-2332-Bump-to-Ruby-3
branch
from
959ca4f
to
70e83f0
Compare
|
I left some auto-corrects that I wasn't sure about, listed here
The first two seem like style preference and wasn't sure what we wanted. |
We definitely want these
We should disable this one since it's no longer relevant for ruby 3+. |
Jammjammjamm
approved these changes
Dec 20, 2023
.simplecov
Outdated
| add_filter "test/" | ||
| add_group "Library", "lib" | ||
| end | ||
| # SimpleCov.start do |
There was a problem hiding this comment.
Remove commented code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2 is no longer receiving security updates/support, so bumping up to Ruby 3. Also updated rubocop to support the newer versions, along with any auto-corrections available with the new cops provided.
ruby_dep was also removed in this update due to a reliance on Ruby 2. It was not used in fhir_models repo, but listing here in case there is a reason we need it specifically.