-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microbiome empty files #40
Conversation
No spelling errors! 🎉 |
|
… into microbiome-draft
…_Genomics_Tools into microbiome-draft
…Genomics_Tools into microbiome-draft
Re-rendered previews from the latest commit:
* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea. Updated at 2024-05-15 with changes from the latest commit 1c2c1cc |
Hi @cansavvy, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a great start!! I like the easy way that this information is communicated that's wonderful and the kind of tone we shoot for! I know you're just looking for big picture at this point so if you're already planning on doing some of the things I mention here no worries.
Some images would be good. People love pictures! :) And some of the info could probably be summarized in bullet point form which would make it quicker for people to scan and absorb.
But otherwise this looks like a good start. Are there other tools besides QIIME2 that people need to know about for microbiome analysis or can QIIME2 really basically handle the whole workflow?
Hi @cansavvy, |
…s_Tools into microbiome-draft
No broken url errors! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just minor comments but I don't feel the need to review again after you take a look at these comments.
To wrap up this project we just need updates to the QIIME2 book right? How's that going and how can I help?
Thanks so much!
13-microbiome.Rmd
Outdated
[Here](https://gregcaporaso.github.io/q2book/front-matter/preface.html) is a high-level introduction to microbiome analysis using QIIME 2. This introduction will go over common methods, metrics and approaches used for microbiome science. | ||
So grab a cup of your favorite hot beverage and let’s get started! ☕ | ||
|
||
## More resources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## More resources | |
## More resources |
Any additional reading you'd recommend in this section? Otherwise we can just delete this header.
Co-authored-by: Candace Savonen <[email protected]>
Co-authored-by: Candace Savonen <[email protected]>
…Genomics_Tools into microbiome-draft
LGTM |
Purpose/implementation Section
What changes are being implemented in this Pull Request?
adding a skeleton outline for the chapter
Tell potential reviewers what kind of feedback you are soliciting.
I dont need review on content yet, but I would like confirmation that this is a reasonable github workflow
New Content Checklist
[ x] New content/chapter is in an Rmd file with this kind of format and headers.
New content/chapter contains Learning Objectives and are in the correct format.
Bookdown successfully re-renders and any new content files have been added to the _bookdown.yml.
Spell check runs successfully in Github actions style-n-check).
Any newly necessary packages that are needed have been added to the Dockerfile and image.
Images are in the correct format for rendering.
Every new image has alt text and is in a Google Slide.
Each slide is described in the notes of the slide so learners relying on a screen reader can access the content. See https://lastcallmedia.com/blog/accessible-comics for more guidance on this.
The color palette choices of the slide are contrasted in a way that is friendly to those with color vision deficiencies.
You can check this using Color Oracle.