Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microbiome empty files #40

Merged
merged 29 commits into from
May 15, 2024
Merged

Microbiome empty files #40

merged 29 commits into from
May 15, 2024

Conversation

cansavvy
Copy link
Contributor

@cansavvy cansavvy commented Nov 16, 2023

Purpose/implementation Section

What changes are being implemented in this Pull Request?

adding a skeleton outline for the chapter

Tell potential reviewers what kind of feedback you are soliciting.

I dont need review on content yet, but I would like confirmation that this is a reasonable github workflow

New Content Checklist

@cansavvy cansavvy requested review from cherman2 and removed request for cherman2 November 16, 2023 20:15
Copy link
Contributor

github-actions bot commented Nov 16, 2023

No spelling errors! 🎉
Comment updated at 2024-05-15-16:09:45 with changes from 1c2c1cc

Copy link
Contributor

github-actions bot commented Nov 16, 2023

⚠️ broken urls ⚠️
There are broken urls that need to be addressed.
Click here ➡️ for broken urls errors!
Add errors that aren't errors to the resources/ignore-urls.txt file of this repo.
If you are having troubles see this guide
Comment updated at 2024-03-06 with changes from f4b4fe2

@cherman2 cherman2 mentioned this pull request Nov 17, 2023
9 tasks
Copy link
Contributor

github-actions bot commented Jan 24, 2024

Re-rendered previews from the latest commit:

* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.

Updated at 2024-05-15 with changes from the latest commit 1c2c1cc

@cherman2
Copy link
Collaborator

cherman2 commented Mar 7, 2024

Hi @cansavvy,
If you could give this a high level overview when you get a chance. Some of the last names are still causing Spell check errors but I will fix that soon!

Copy link
Contributor Author

@cansavvy cansavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great start!! I like the easy way that this information is communicated that's wonderful and the kind of tone we shoot for! I know you're just looking for big picture at this point so if you're already planning on doing some of the things I mention here no worries.

Some images would be good. People love pictures! :) And some of the info could probably be summarized in bullet point form which would make it quicker for people to scan and absorb.

But otherwise this looks like a good start. Are there other tools besides QIIME2 that people need to know about for microbiome analysis or can QIIME2 really basically handle the whole workflow?

13-microbiome.Rmd Outdated Show resolved Hide resolved
13-microbiome.Rmd Show resolved Hide resolved
@cherman2
Copy link
Collaborator

cherman2 commented Apr 16, 2024

Hi @cansavvy,
I addressed most of your comments! Thank you for your feedback. I am now just waiting for the rendered version to be updated! I am going to run this by Greg once I spot check the rendered version!

@fhdsl fhdsl deleted a comment from github-actions bot Apr 23, 2024
Copy link
Contributor

github-actions bot commented Apr 23, 2024

No broken url errors! 🎉
Comment updated at 2024-05-15-16:09:52 with changes from 1c2c1cc

Copy link
Contributor Author

@cansavvy cansavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just minor comments but I don't feel the need to review again after you take a look at these comments.

To wrap up this project we just need updates to the QIIME2 book right? How's that going and how can I help?

Thanks so much!

13-microbiome.Rmd Outdated Show resolved Hide resolved
13-microbiome.Rmd Show resolved Hide resolved
[Here](https://gregcaporaso.github.io/q2book/front-matter/preface.html) is a high-level introduction to microbiome analysis using QIIME 2. This introduction will go over common methods, metrics and approaches used for microbiome science.
So grab a cup of your favorite hot beverage and let’s get started! ☕

## More resources
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## More resources
## More resources

Any additional reading you'd recommend in this section? Otherwise we can just delete this header.

@cansavvy
Copy link
Contributor Author

LGTM

@cansavvy cansavvy merged commit 8d389ae into main May 15, 2024
8 checks passed
@cansavvy cansavvy deleted the microbiome-draft branch May 15, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants