[bad PR] #90
Closed
[bad PR] #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Leonardo Schwarz <[email protected]>
Co-authored-by: Leonardo Schwarz <[email protected]>
Co-authored-by: Leonardo Schwarz <[email protected]>
Co-authored-by: Leonardo Schwarz <[email protected]>
Co-authored-by: Leonardo Schwarz <[email protected]>
Co-authored-by: Leonardo Schwarz <[email protected]>
Co-authored-by: Leonardo Schwarz <[email protected]>
Feat response formats
… added dict-sorting by key feature for easier comparison of Zeep and Suds
Bugfix bfabric2 login
Handle default `None` parameters in BfabricConfig
… endpoints. extended use BfabricRequestError to correctly handle bad delete queries and multiple responses
- This migrates the project configuration to `pyproject.toml`. - In a next step we can update the folder structure as well. - Scripts can be added once we add a `main` function to them, which will be done in separate PRs.
The code itself has not been changed, nor does it use the new API.
Refactor list not available proteomics workunits
Use configured url
- Use `uv` - Adds: - Code style (does not need to pass) - License check
- Make managing the `BfabricAuth` object the responsibility of the `Bfabric` class. This allows us to implement the contextmanager, which will be useful for the REST-proxy server. - Notably this shouldn't change anything about code that already uses the new class. - Rename `BfabricConfig.with_overrides` to `BfabricConfig.copy_with` for clarity. - Some unit tests for the Bfabric class, I will add more as I go.
- New pagination logic: - Specify max number of items - Specify offset of items to skip - Stable reading - Reading passes a `createdbefore` query field (if it's not part of the query) to ensure consistent reads/pagination in the presence of insertions into the database. Deletions are not handled and might require an API feature. - It will need to be tested further before releasing, but my idea is that this is a lot more flexible moving forward - New `Bfabric.from_config` arguably it is a bit redundant with the `get_system_auth` method, however I do feel like 99% of use cases will be handled with this method now and it will be easier to do so. I'm not changing the usage in this PR yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.