Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new pagination interface, more stable reads, Bfabric.from_config #85

Merged
merged 2 commits into from
May 7, 2024

Conversation

leoschwarz
Copy link
Collaborator

@leoschwarz leoschwarz commented May 7, 2024

This mixes 3 different concerns, but it will make it much quicker for me to bundle these changes than separate them out from the branch where they are integrated already:

  • New pagination logic:
    • Specify max number of items
    • Specify offset of items to skip
  • Stable reading
    • Reading passes a createdbefore query field (if it's not part of the query) to ensure consistent reads/pagination in the presence of insertions into the database. Deletions are not handled and might require an API feature.
    • It will need to be tested further before releasing, but my idea is that this is a lot more flexible moving forward
  • New Bfabric.from_config arguably it is a bit redundant with the get_system_auth method, however I do feel like 99% of use cases will be handled with this method now and it will be easier to do so. I'm not changing the usage in this PR yet.

@leoschwarz leoschwarz changed the title Pagination interface + Bfabric.from_config new pagination interface, stable reads, Bfabric.from_config May 7, 2024
@leoschwarz leoschwarz marked this pull request as ready for review May 7, 2024 10:18
@leoschwarz leoschwarz changed the title new pagination interface, stable reads, Bfabric.from_config new pagination interface, more stable reads, Bfabric.from_config May 7, 2024
@leoschwarz leoschwarz merged commit 1472332 into dev-bfabric-2 May 7, 2024
3 checks passed
@leoschwarz leoschwarz deleted the pagination-interface branch May 7, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants