Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move auth logic to Bfabric class #79

Merged
merged 3 commits into from
May 7, 2024

Conversation

leoschwarz
Copy link
Collaborator

@leoschwarz leoschwarz commented May 3, 2024

  • Make managing the BfabricAuth object the responsibility of the Bfabric class. This allows us to implement the contextmanager, which will be useful for the REST-proxy server.
    • Notably this shouldn't change anything about code that already uses the new class.
  • Rename BfabricConfig.with_overrides to BfabricConfig.copy_with for clarity.
  • Some unit tests for the Bfabric class, I will add more as I go.

@leoschwarz leoschwarz marked this pull request as ready for review May 3, 2024 07:02
@aleksejs-fomins
Copy link
Collaborator

aleksejs-fomins commented May 3, 2024 via email

@leoschwarz leoschwarz merged commit 2afcd0c into dev-bfabric-2 May 7, 2024
3 checks passed
@leoschwarz leoschwarz deleted the move-auth-logic-to-bfabric-class branch May 7, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants