Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: improve scripts #29

Merged
merged 10 commits into from
Jul 3, 2023
Merged

Chore: improve scripts #29

merged 10 commits into from
Jul 3, 2023

Conversation

ffoodd
Copy link
Owner

@ffoodd ffoodd commented Jul 3, 2023

Upstream

I couldn't find a way to disable no-unsanitized linter rules using web-ext lint, but it worked fine using addons-linter --disable-linter-rules. I opened an issue upstream but might end up using addons-linter directly, since it's installed anyway.

FWIW there's also an issue when running web-ext run for Firefox on Ubuntu, because it's installed via Snap. This is a known bug and there are workarounds but I'm not getting into it for now.

@ffoodd ffoodd force-pushed the chore/manifest-version-bump branch 5 times, most recently from e91cfe6 to 6e0e3aa Compare July 3, 2023 15:16
@ffoodd ffoodd force-pushed the chore/manifest-version-bump branch from 8d2a8cf to 969d965 Compare July 3, 2023 15:21
@ffoodd ffoodd self-assigned this Jul 3, 2023
@ffoodd ffoodd added enhancement New feature or request dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Jul 3, 2023
@ffoodd ffoodd merged commit 538a1c5 into main Jul 3, 2023
1 check passed
@ffoodd ffoodd deleted the chore/manifest-version-bump branch July 3, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle browser-specific manifest when bumping version Use web-ext ?
1 participant