chore: remove containers and unset formatter (#1582)

- Remove containers when not needed anymore - Unset Prettier formatter when not needed
ferrarimarco · Sep 9, 2024 · 0d1d457 · 0d1d457
1 parent 8d03415
commit 0d1d457
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 1 deletion.
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -5,7 +5,6 @@
   "customizations": {
     "vscode": {
       "settings": {
-        "editor.defaultFormatter": "esbenp.prettier-vscode",
         "editor.formatOnSave": true,
         "editor.formatOnSaveMode": "file",
         "editor.wordWrap": "off",

diff --git a/scripts/lint-commits.sh b/scripts/lint-commits.sh
@@ -32,6 +32,7 @@ fi
 
 # shellcheck disable=SC2206
 LINT_COMMITS_COMMAND+=(
+  --rm
   --volume "$(pwd):/source-repository"
   "${CD_CONTAINER_URL}"
   commitlint

diff --git a/scripts/release-please-dry-run.sh b/scripts/release-please-dry-run.sh
@@ -14,6 +14,7 @@ check_github_token_file
 
 echo "Running release-please against branch: ${RELEASE_PLEASE_TARGET_BRANCH}"
 docker run \
+  --rm \
   --volume "$(pwd):/source-repository" \
   "${CD_CONTAINER_URL}" \
   release-please \

diff --git a/scripts/run-renovate.sh b/scripts/run-renovate.sh
@@ -34,6 +34,7 @@ RENOVATE_COMMAND+=(
   --env LOG_FORMAT="json"
   --env RENOVATE_CONFIG_FILE="${RENOVATE_CONFIG_FILE}"
   --env RENOVATE_TOKEN="$(cat "${GITHUB_TOKEN_PATH}")"
+  --rm
   --volume "${RENOVATE_CONFIG_FILE}":"${RENOVATE_CONFIG_FILE}"
   "${RENOVATE_CONTAINER_IMAGE}"
   renovate