feat(push): allow pushing composed components to registry #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fibonacci1729
commented
Jan 28, 2025
fibonacci1729
force-pushed
the
push
branch
3 times, most recently
from
ee371d1 to
9176ca1
Compare
itowlson
reviewed
Jan 30, 2025
crates/oci/src/client.rs
Outdated
| for (dep_name, mut dep) in c.dependencies { | ||
| let source = dep | ||
| if !skip_compose { | ||
| let composed = spin_compose::compose(&ComponentSourceLoader, &c) |
There was a problem hiding this comment.
It feels awkward for an assemble_layers function to contain composition logic.
What would be the tradeoffs of doing composition as e.g. a LockedApp -> LockedApp transformation invoked after locking, and not touching the (core) OCI code at all? I guess it would force us to create temp files rather than holding compositions only in memory... which is a bit yuck...
There was a problem hiding this comment.
Yeah i considered that but ended up abandoning it for "less code"... Happy to revisit if this is too awkward.
fibonacci1729
force-pushed
the
push
branch
2 times, most recently
from
895614d to
2ba49e1
Compare
|
cc/ @itowlson a simple test is now included. |
Signed-off-by: Brian H <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for now to flesh out the concept.Implements #2988
Still working to add a test but the meat-and-potatoes is ready to serve.