Use the original instance_url for soap auth #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @54sledgehammer45! Thank you for the PR! This is a very valid point! I would like to test this before merging though. As I remember, the reason I went with this solution is that you might use test.salesforce.com as your initial instance-url, but then once logged in, you're provided with your personal instance url. I will confirm this :) |
The explicitly set server/instance URL was being overriden by what the server returned. There are however probably good reasons for the original URL to be set by the developer. Ignoring the developer's decision without giving an option to override, forces the developer to copy-paste and rewrite code that uses the method. This commit makes that unnecessary. Fixes felixlindstrom#21 : SOAP auth overwrites instance URL
54sledgehammer45
force-pushed
the
21-use-original-instance-url
branch
from
dfdf460
to
8e1b2a8
Compare
|
Hey @felixlindstrom, My tests weren't extensive enough and I just tested that it could login. Other calls to the endpoints were failing. That's fixed in the last force-push. I wasn't aware of Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The explicitly set server/instance URL was being overriden by what the server returned.
There are however probably good reasons for the original URL to be set by the developer.
Ignoring the developer's decision without giving an option to override,
forces the developer to copy-paste and rewrite code that uses the method.
This commit makes that unnecessary.
Fixes #21 : SOAP auth overwrites instance URL