Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOAP auth overwrites instance URL #21

Open
54sledgehammer45 opened this issue Jul 5, 2021 · 0 comments · May be fixed by #22
Open

SOAP auth overwrites instance URL #21

54sledgehammer45 opened this issue Jul 5, 2021 · 0 comments · May be fixed by #22

Comments

@54sledgehammer45
Copy link

python-salesforce-api/salesforce_api/login.py

Line 101 in 37ed67b

instance = re.match(r'(https://(.*).salesforce\.com/)', server_url).group(1)

This creates a bug with reverse proxies or firewalled environments that specifically whitelist certain URLs.

Using the existing instance_url to make the call to plain_access_token(instance_url=instance_url,...) would fix it.
54sledgehammer45 added a commit to NL-ix/python-salesforce-api that referenced this issue Jul 5, 2021
@54sledgehammer45
Use the original instance_url for soap auth
dfdf460 
The explicitly set server/instance URL was being overriden by what the server returned.
There are however probably good reasons for the original URL to be set by the developer.
Ignoring the developer's decision without giving an option to override,
 forces the developer to copy-paste and rewrite code that uses the method.

This commit makes that unnecessary.

Fixes felixlindstrom#21 : SOAP auth overwrites instance URL
@54sledgehammer45 54sledgehammer45 linked a pull request Jul 5, 2021 that will close this issue
Open
54sledgehammer45 added a commit to NL-ix/python-salesforce-api that referenced this issue Jul 7, 2021
@54sledgehammer45
Use the original instance_url for soap auth
8e1b2a8 
The explicitly set server/instance URL was being overriden by what the server returned.
There are however probably good reasons for the original URL to be set by the developer.
Ignoring the developer's decision without giving an option to override,
 forces the developer to copy-paste and rewrite code that uses the method.

This commit makes that unnecessary.

Fixes felixlindstrom#21 : SOAP auth overwrites instance URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the original instance_url for soap auth NL-ix/python-salesforce-api
1 participant
@54sledgehammer45