fix: Don't create dynamic property in Dispatcher #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
=========================================
Coverage 89.07% 89.07%
Complexity 58 58
=========================================
Files 8 8
Lines 119 119
=========================================
Hits 106 106
Misses 13 13
|
https://wiki.php.net/rfc/deprecate_dynamic_properties causes this to emit an E_DEPRECATION notice in php 8.2+ and this will throw an Error in php 9.0 A private property was chosen because: - This was undocumented and I assume unintentional. - This will not conflict with any properties of the same name and different types (or readonly properties) in subclasses.
TysonAndre
force-pushed
the
fix-deprecated-dynamic-property
branch
from
e3ad6e3 to
6a2482d
Compare
TysonAndre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wiki.php.net/rfc/deprecate_dynamic_properties
causes this to emit an E_DEPRECATION notice and this will throw in PHP 9.0 unless subclasses happen to declare that property as protected/public
A private property was proposed because:
different types (or readonly properties) in subclasses.