-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: add obliterator to benchmarks #25
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🏃
package.json
Outdated
@@ -85,6 +85,7 @@ | |||
"lodash": "^4.17.11", | |||
"mocha": "^6.1.4", | |||
"nyc": "^14.1.1", | |||
"obliterator": "github:forivall/obliterator#patch-1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a PR for this we can wait for so I don't have to depend on a GitHub reference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it did get merged. Yomguithereal/obliterator#18. will update in a mo'
Switch to a published version of obliterator
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
=======================================
Coverage 93.25% 93.25%
=======================================
Files 8 8
Lines 163 163
Branches 29 29
=======================================
Hits 152 152
Misses 11 11 Continue to review full report at Codecov.
|
(updated) |
I was curious about the performance compared to obliterator (using my fork to fix the type definitions), so i added it to the benchmark. You're still the fastest lib.