Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add obliterator to benchmarks #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

forivall
Copy link
Contributor

I was curious about the performance compared to obliterator (using my fork to fix the type definitions), so i added it to the benchmark. You're still the fastest lib.

~pubrepos/iterare master*
» node ./lib/benchmarks/filter_take_set.js
Loop x 2,102,039 ops/sec ±1.37% (86 runs sampled)
iterare x 603,265 ops/sec ±2.23% (82 runs sampled)
Array method chain x 43.79 ops/sec ±1.17% (57 runs sampled)
Lodash x 642 ops/sec ±1.19% (85 runs sampled)
RxJS x 110,212 ops/sec ±4.47% (88 runs sampled)
IxJS (ES5) x 359,412 ops/sec ±1.11% (89 runs sampled)
IxJS (ES6) x 325,086 ops/sec ±2.87% (82 runs sampled)
obliterator x 416,279 ops/sec ±1.95% (87 runs sampled)
Fastest is Loop

~pubrepos/iterare master* 49s
» node ./lib/benchmarks/map_filter_set.js
Loop x 408 ops/sec ±1.96% (83 runs sampled)
iterare x 382 ops/sec ±1.06% (83 runs sampled)
Array method chain x 340 ops/sec ±5.81% (84 runs sampled)
Lodash x 363 ops/sec ±1.36% (85 runs sampled)
RxJS x 342 ops/sec ±1.36% (84 runs sampled)
IxJS (ES5) x 201 ops/sec ±2.41% (80 runs sampled)
IxJS (ES6) x 212 ops/sec ±1.09% (81 runs sampled)
obliterator x 258 ops/sec ±1.29% (79 runs sampled)
Fastest is Loop

Copy link
Owner

@felixfbecker felixfbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🏃

package.json Outdated
@@ -85,6 +85,7 @@
"lodash": "^4.17.11",
"mocha": "^6.1.4",
"nyc": "^14.1.1",
"obliterator": "github:forivall/obliterator#patch-1",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a PR for this we can wait for so I don't have to depend on a GitHub reference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it did get merged. Yomguithereal/obliterator#18. will update in a mo'

Switch to a published version of obliterator
@codecov
Copy link

codecov bot commented Feb 15, 2020

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files           8        8           
  Lines         163      163           
  Branches       29       29           
=======================================
  Hits          152      152           
  Misses         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9483424...99d72a9. Read the comment docs.

@forivall
Copy link
Contributor Author

(updated)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants