Remove foxy leftovers

felixdivo · May 11, 2024 · 2651af8 · 2651af8
1 parent 781ee2a
commit 2651af8
Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/ros2_easy_test/tests/test_env_coverage.py b/ros2_easy_test/tests/test_env_coverage.py
@@ -91,7 +91,7 @@ def test_mailbox_clearing_no_topics(self, env: ROS2TestEnvironment) -> None:
     @mark.xfail(
         raises=Exception,
         reason="specifiying a wrong message type is a common mistake and shall fail loudly",
-        strict=not is_ros_version("foxy"),  # It does fail on foxy
+        strict=True,
     )
     @with_single_node(EchoNode, watch_topics={"/mouth": Empty})
     def test_wrong_topic_type(self, env: ROS2TestEnvironment) -> None:

diff --git a/ros2_easy_test/tests/test_failing_nodes.py b/ros2_easy_test/tests/test_failing_nodes.py
@@ -121,7 +121,6 @@ def test_service_callback_failure_sync(self, env: ROS2TestEnvironment) -> None:
         reason="Failures in a service callback should be propagated to the test.",
         strict=False,  # TODO: It would be nice to fix this some time -> make it strict=True
         # At least this one doesn't deadlock, but it still doesn't work
-        run=not is_ros_version("foxy"),  # TODO: Somehow deadlocks
     )
     @with_single_node(NodeRaiseOnRequest)
     def test_service_callback_failure_async(self, env: ROS2TestEnvironment) -> None:
@@ -185,7 +184,6 @@ def test_service_callback_failure_sync(self, env: ROS2TestEnvironment) -> None:
         reason="Failures in a service callback should be propagated to the test.",
         strict=False,  # TODO: It would be nice to fix this some time -> make it strict=True
         # At least this one doesn't deadlock, but it still doesn't work
-        run=not is_ros_version("foxy"),  # TODO: Somehow deadlocks
     )
     @with_launch_file(BASE / "raise_on_request.yaml", warmup_time=2)
     def test_service_callback_failure_async(self, env: ROS2TestEnvironment) -> None: