Multitread version with dynamic resolving #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltiply IPs for one destination servers, work with failures when resolving
|
Sorry - please, remove sleep(1) from run_dispatcher() |
felixcarmona
approved these changes
Nov 27, 2019
|
Hello! Thanks for the PR, overall it looks good for me, I just left you few minor things. I would appreciate it if you have some time to review them before merging it |
remove unnecessary "\n" print
|
Hello Felix! Why didn't you merge my pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Felix! I've made dynamic resolving of the servers on separate thread - everything works fine.
Also this version use all IPs of the server - not only first.
Best wishes!