Optimize allocations for the common path in TimeSeriesIdFieldMapper

felixbarny · Sep 12, 2024 · 2d4f48d · 2d4f48d
1 parent 8ad80b3
commit 2d4f48d
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/server/src/main/java/org/elasticsearch/index/mapper/TimeSeriesIdFieldMapper.java b/server/src/main/java/org/elasticsearch/index/mapper/TimeSeriesIdFieldMapper.java
@@ -184,7 +184,7 @@ public static class TimeSeriesIdBuilder implements DocumentDimensions {
         private final Murmur3Hasher tsidHasher = new Murmur3Hasher(0);
 
         /**
-         * A sorted set of the serialized values of dimension fields that will be used
+         * A map of the serialized values of dimension fields that will be used
          * for generating the _tsid field. The map will be used by {@link TimeSeriesIdFieldMapper}
          * to build the _tsid field for the document.
          */
@@ -210,6 +210,7 @@ public BytesReference buildLegacyTsid() throws IOException {
                     out.writeBytesRef(entry.getKey());
                     List<BytesReference> value = entry.getValue();
                     if (value.size() > 1) {
+                        // multi-value dimensions are only supported for newer indices that use buildTsidHash
                         throw new IllegalArgumentException(
                             "Dimension field [" + entry.getKey().utf8ToString() + "] cannot be a multi-valued field."
                         );
@@ -276,7 +277,9 @@ public BytesReference buildTsidHash() {
             // NOTE: hash all dimension field allValues
             tsidHasher.reset();
             for (final List<BytesReference> values : dimensions.values()) {
-                values.forEach(v -> tsidHasher.update(v.toBytesRef().bytes));
+                for (BytesReference v : values) {
+                    tsidHasher.update(v.toBytesRef().bytes);
+                }
             }
             tsidHashIndex = writeHash128(tsidHasher.digestHash(), tsidHash, tsidHashIndex);
 
@@ -383,10 +386,15 @@ private void add(String fieldName, BytesReference encoded) throws IOException {
             List<BytesReference> values = dimensions.get(name);
             if (values == null) {
                 // optimize for the common case where dimensions are not multi-valued
-                values = new ArrayList<>(1);
-                values.add(encoded);
-                dimensions.put(name, values);
+                dimensions.put(name, List.of(encoded));
             } else {
+                if (values.size() == 1) {
+                    // converts the immutable list that's optimized for the common case of having only one value to a mutable list
+                    BytesReference previousValue = values.get(0);
+                    values = new ArrayList<>(4);
+                    values.add(previousValue);
+                    dimensions.put(name, values);
+                }
                 values.add(encoded);
             }
         }