Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serde: add deserializer and remove useless code #869

Merged
merged 5 commits into from
Aug 25, 2024
Merged

Conversation

cosven
Copy link
Member

@cosven cosven commented Aug 21, 2024

http post http://127.0.0.1:23332/rpc/v1 jsonrpc='2.0' method='app.playlist.play_model' params:='[{"__type__": "feeluown.library.BriefSongModel","album_name": "吻别","artists_name": "张学友","duration_ms": "00:00","identifier": "bZn1Pb2Ei64","provider": "ytmusic","uri": "fuo://ytmusic/songs/bZn1Pb2Ei64","title": "吻别"}]' id=1

@cosven cosven changed the title serde: remove useless code serde: add deserializer and remove useless code Aug 21, 2024
@coveralls
Copy link

coveralls commented Aug 21, 2024

Pull Request Test Coverage Report for Build 10545996589

Details

  • 169 of 220 (76.82%) changed or added relevant lines in 7 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 55.366%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/serializers/init.py 21 23 91.3%
feeluown/serializers/plain.py 39 41 95.12%
feeluown/serializers/python.py 33 38 86.84%
feeluown/serializers/base.py 7 15 46.67%
feeluown/webserver/jsonrpc_.py 0 16 0.0%
feeluown/serializers/objs.py 47 65 72.31%
Files with Coverage Reduction New Missed Lines %
feeluown/webserver/jsonrpc_.py 1 0.0%
feeluown/serializers/python.py 1 91.43%
Totals Coverage Status
Change from base Build 10441767621: 0.3%
Covered Lines: 9973
Relevant Lines: 18013

💛 - Coveralls

@cosven cosven merged commit 98f0215 into feeluown:master Aug 25, 2024
9 checks passed
@cosven cosven deleted the serde branch August 25, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants