Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

player: slightly refactor metadata manager #856

Merged
merged 2 commits into from
Jul 27, 2024

Conversation

cosven
Copy link
Member

@cosven cosven commented Jul 24, 2024

No description provided.

@coveralls
Copy link

coveralls commented Jul 24, 2024

Pull Request Test Coverage Report for Build 10121459552

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 40 of 59 (67.8%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 55.108%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/player/playlist.py 4 5 80.0%
feeluown/player/metadata_assembler.py 35 53 66.04%
Totals Coverage Status
Change from base Build 9933697122: 0.05%
Covered Lines: 9867
Relevant Lines: 17905

💛 - Coveralls

@cosven cosven merged commit 1f6496e into feeluown:master Jul 27, 2024
9 checks passed
@cosven cosven deleted the metadata-refactor branch July 27, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants