Adding support for IPoIB interfaces #297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmousa
force-pushed
the
ipoib_support
branch
from
8a65a3e
to
2a4a165
Compare
wmousa
changed the title
jamacku
requested changes
Dec 19, 2019
jamacku
requested changes
Dec 19, 2019
network-scripts/ifup
Outdated
| net_log $"ERROR: could not add pkey ${PKEY_ID} as ${DEVICE} on dev ${PHYSDEV}" | ||
| exit 1 | ||
| } | ||
| fi |
There was a problem hiding this comment.
Also please set spacing of this and following line to 4 spaces. Thank you.
wmousa
force-pushed
the
ipoib_support
branch
from
2a4a165
to
54afbc4
Compare
The patch allow to ifup/ifdown IpoIB interfaces from network-scripts The required config is the following DEVICE=ib0.8005 # ib0 the it IB interface TYPE=Infiniband # the type is Infiniband PKEY=yes # indicator that it's IPoIB interface PKEY_ID=5 # the pkey number
wmousa
force-pushed
the
ipoib_support
branch
from
54afbc4
to
b4331f2
Compare
Done |
|
We were just discussing this with @jamacku on Friday and I have a feeling that this should not be here. At least on rhel7, there is a rdma package with contains ifup-ib and ifdown-ib scripts. So my guess is that you actually want to have this logic in https://github.com/Mellanox/rdma-utils |
|
Mellanox/rdma-utils is a repository that is used internally in Mellanox it has a bunch of other stuff that is not needed, nor is it maintained. ipoib configurations is standard and should not be in a vendor specific repo imo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch allow to ifup/ifdown IPoIB interfaces from network-scripts
The required config is the following
DEVICE=ib0.8005 # ib0 the is IB interface
TYPE=Infiniband # the type is Infiniband
PKEY=yes # indicator that it's IPoIB interface
PKEY_ID=5 # the pkey number