Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

00440: gh-124160: Pass main_tstate to update_global_state_for_extensi… #88

Closed
wants to merge 1 commit into from

Conversation

luk1337
Copy link

@luk1337 luk1337 commented Sep 19, 2024

No description provided.

@hroncok
Copy link
Member

hroncok commented Sep 19, 2024

Hey @luk1337. Do you need this in the Fedora package? What is the context?

@luk1337
Copy link
Author

luk1337 commented Sep 19, 2024

Hey @luk1337. Do you need this in the Fedora package? What is the context?

Yes, this fixes a pretty critical bug IMO that affects the package I maintain.

@hroncok
Copy link
Member

hroncok commented Sep 19, 2024

I see. I can get it in. Thanks for the PR.

@hroncok
Copy link
Member

hroncok commented Sep 19, 2024

I rebased this slightly but I cannot push it into your branch. Could you please allow that in the PR options? It's not a big deal, except this won't be marked as merged if I don't do that.

@luk1337
Copy link
Author

luk1337 commented Sep 19, 2024

I rebased this slightly but I cannot push it into your branch. Could you please allow that in the PR options? It's not a big deal, except this won't be marked as merged if I don't do that.

It was already enabled
image

@luk1337
Copy link
Author

luk1337 commented Sep 19, 2024

I rebased this slightly but I cannot push it into your branch. Could you please allow that in the PR options? It's not a big deal, except this won't be marked as merged if I don't do that.

It was already enabled image

I just clicked it twice tho, maybe that'll help somehow

@hroncok
Copy link
Member

hroncok commented Sep 19, 2024

ERROR: Permission to luk1337/cpython.git denied to hroncok.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

:/

Nevermind. It's not important.

@luk1337
Copy link
Author

luk1337 commented Sep 19, 2024

yeah, I'm fine with you just pushing to origin instead.

@luk1337 luk1337 closed this Sep 19, 2024
@luk1337 luk1337 deleted the luk/import branch September 19, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants