Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy Python tests for Modulemd.ModuleStream.rpm_artifacts into C #411

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Copy Python tests for Modulemd.ModuleStream.rpm_artifacts into C #411

merged 1 commit into from
Jan 8, 2020

Conversation

srikavin
Copy link
Contributor

This is related to #199.

OrionStar25
OrionStar25 approved these changes Dec 25, 2019
View reviewed changes
Copy link
Member

@OrionStar25 OrionStar25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM :D
Travis is failing because the docker for Fedora 64 arch is facing a compilation issue. A macro apparently has 2 different definitions. Doesn't seem related to your code though.

sgallagher
sgallagher requested changes Jan 7, 2020
View reviewed changes
Copy link
Collaborator

@sgallagher sgallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the GDate macro issue in the latest master, which also contains some other conflicts. Please do git rebase to the latest master; this should work properly now.

@srikavin
Copy link
Contributor Author

srikavin commented Jan 8, 2020

@sgallagher I've rebased my branch onto master.

@sgallagher sgallagher merged commit 2eb2ac7 into fedora-modularity:master Jan 8, 2020
@srikavin srikavin deleted the test-rpm-artifacts branch January 8, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgallagher sgallagher sgallagher approved these changes

@OrionStar25 OrionStar25 OrionStar25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srikavin @sgallagher @OrionStar25