Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy Python tests for Modulemd.ModuleStream.licenses into C #408

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Copy Python tests for Modulemd.ModuleStream.licenses into C #408

merged 1 commit into from
Jan 7, 2020

Conversation

srikavin
Copy link
Contributor

This is related to #199.

OrionStar25
OrionStar25 suggested changes Dec 14, 2019
View reviewed changes
Copy link
Member

@OrionStar25 OrionStar25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good start! We always aim for thorough testing and hence I've requested some changes.

modulemd/tests/test-modulemd-modulestream.c Show resolved Hide resolved
modulemd/tests/test-modulemd-modulestream.c Show resolved Hide resolved
modulemd/tests/test-modulemd-modulestream.c Show resolved Hide resolved
modulemd/tests/test-modulemd-modulestream.c Show resolved Hide resolved
@srikavin
Copy link
Contributor Author

@OrionStar25 I've made the changes that you suggested

OrionStar25
OrionStar25 approved these changes Dec 15, 2019
View reviewed changes
Copy link
Member

@OrionStar25 OrionStar25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks a lot

@sgallagher sgallagher merged commit 01e8dce into fedora-modularity:master Jan 7, 2020
@srikavin srikavin deleted the license-test branch January 8, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgallagher sgallagher sgallagher approved these changes

@OrionStar25 OrionStar25 OrionStar25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srikavin @sgallagher @OrionStar25