Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy Python tests for Modulemd.ModuleStream.components into C #402

Merged
merged 2 commits into from
Dec 12, 2019
Merged

Copy Python tests for Modulemd.ModuleStream.components into C #402

merged 2 commits into from
Dec 12, 2019

Conversation

srikavin
Copy link
Contributor

This is related to #199. I also added checks to see if the components were properly removed.

OrionStar25
OrionStar25 approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@OrionStar25 OrionStar25 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on adding the empty list check after removing a component! LGTM overall.

CI is failing because OpenMandriva docker failed to build.

sgallagher
sgallagher requested changes Dec 12, 2019
View reviewed changes
Copy link
Collaborator

@sgallagher sgallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Just a few tweaks.

modulemd/tests/test-modulemd-modulestream.c Show resolved Hide resolved
modulemd/tests/test-modulemd-modulestream.c Outdated Show resolved Hide resolved
modulemd/tests/test-modulemd-modulestream.c Outdated Show resolved Hide resolved
modulemd/tests/test-modulemd-modulestream.c Show resolved Hide resolved
@srikavin
Compare components using modulemd_component_equals
cea197f 
and added check for adding components in module_stream_test_components
@srikavin
Copy link
Contributor Author

@sgallagher I've added changes that you suggested

sgallagher
sgallagher approved these changes Dec 12, 2019
View reviewed changes
Copy link
Collaborator

@sgallagher sgallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sgallagher sgallagher merged commit 163ff82 into fedora-modularity:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgallagher sgallagher sgallagher approved these changes

@OrionStar25 OrionStar25 OrionStar25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srikavin @sgallagher @OrionStar25