Copy Python tests for Modulemd.ModuleStream.documentation into C #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrionStar25
approved these changes
Dec 4, 2019
sgallagher
requested changes
Dec 4, 2019
There was a problem hiding this comment.
It looks mostly good. I'd like you to do two things:
- You have
"http://redhat.com"and"documentation"copied-and-pasted in many places. I'd rather see you use#define MMD_TEST_DOC_TEXT "http://redhat.com"and#define MMD_TEST_DOC_PROP "documentation"instead, so if we ever want to change the values, we only need to change one place. - I'd like you to store and get a string for the documentation value that includes non-ASCII characters such as:
- À
- ϶
- ￥
- 🌭
I realize the unicode requirement wasn't in the python version of the test, but that was an oversight on my part. Please correct that while you're in this code.
Fixes a possible double free as get_documentation does not transfer ownership
|
@sgallagher, I've replaced the hard-coded values with defines and added a Unicode test to both the C and Python tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies the Python test
test_documentationinto C. This is related to #199.