Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Python tests for Modulemd.ModuleStream.profiles into C #396

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Conversation

srikavin
Copy link
Contributor

@srikavin srikavin commented Dec 3, 2019

This copies the Python test test_profiles into C. This is related to #199.

@OrionStar25
Copy link
Member

OrionStar25 commented Dec 4, 2019

@srikavin Travis is failing because OpenSuse's docker file could not build properly. This doesn't have anything to do with your code though.

@sgallagher Could you please resubmit the task, or am I missing something really important that is failing CI?

@OrionStar25
Copy link
Member

Btw, @srikavin is a Google Code-In participant and this is the first actual contribution for Fedora this year 🔥

@sgallagher
Copy link
Collaborator

@srikavin Travis is failing because OpenSuse's docker file could not build properly. This doesn't have anything to do with your code though.

@sgallagher Could you please resubmit the task, or am I missing something really important that is failing CI?

Yeah, this looks like it may actually be a problem in openSUSE. I've resubmitted it anyway.

@sgallagher
Copy link
Collaborator

Btw, @srikavin is a Google Code-In participant and this is the first actual contribution for Fedora this year

Welcome, @srikavin! It's nice to work with you. I'll review your code shortly.

Copy link
Collaborator

@sgallagher sgallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks very much for your contribution.

@sgallagher sgallagher merged commit f10d1aa into fedora-modularity:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants