Copies some python test of modulestream into C #211
Conversation
| modulemd_module_stream_depends_on_stream (stream, "platform", "f30")); | ||
| g_clear_object (&stream); | ||
|
|
||
| stream = modulemd_module_stream_read_file ( |
There was a problem hiding this comment.
You don't need to read the file again. You can perform this test with the same ModulemdModuleStream object you used for line 523.
There was a problem hiding this comment.
Please fix this for all of the tests below and in the v2 version. After that, this should be good to merge.
|
I have made the mentioned changes. |
There was a problem hiding this comment.
@athira-selvam Before submitting your code, please make sure to run ninja test on it locally. Among other things, this will put it through the code formatter. The CI tests check to see if the code matches the format convention and throws an error.
Once you resubmit with the formatting fixed, I think this is ready to merge.
Most of the tests for ModuleStream objects are run under Python. The valgrind tests for identifying memory leaks and errors can only run against tests in the C. The tests for ModuleStream.depends_on_stream have been copied from Python to C. issue : fedora-modularity#199
|
I ran the ninja testa and have pushed the corrected code. |
Most of the tests for ModuleStream objects are run under Python.
The valgrind tests for identifying memory leaks and errors can only
run against tests in the C code.
The tests for ModuleStream.depends_on_stream have been copied from
Python to C.
issue : #199