Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing en keys and run translate #526

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

Kodylow
Copy link
Member

@Kodylow Kodylow commented Sep 18, 2024

Summary by CodeRabbit

  • New Features
    • Added a "urlLabel" for the URL input field across multiple language localizations to enhance clarity.
    • Introduced a new "home" section in various languages, providing labels for services, guardians, actions, and gateways to improve navigation and user experience.

These updates enhance the application's usability by offering clearer labels and more options for users in their preferred language.

@Kodylow Kodylow requested a review from a team as a code owner September 18, 2024 16:02
Copy link
Contributor

coderabbitai bot commented Sep 18, 2024

Walkthrough

Walkthrough

The changes involve the addition of a "urlLabel" key in the "notConfigured" section and a new "home" section across multiple language JSON files. The "home" section includes various entries related to services, guardians, actions, and gateways, enhancing the application's localization and user interface.

Changes

Files Change Summary
apps/router/src/languages/ca.json, de.json, en.json, es.json, fr.json, hu.json, it.json, ja.json, ko.json, pt.json, ru.json, zh.json Added "urlLabel": "URL" in the "notConfigured" section and a new "home" section with various entries related to services, guardians, actions, and gateways.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Application
    User->>Application: Access configuration
    Application-->>User: Display "notConfigured" section with "urlLabel"
    User->>Application: Navigate to home section
    Application-->>User: Display services, guardians, actions, and gateways
Loading

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c445992 and 9859d0c.

Files selected for processing (12)
  • apps/router/src/languages/ca.json (2 hunks)
  • apps/router/src/languages/de.json (2 hunks)
  • apps/router/src/languages/en.json (2 hunks)
  • apps/router/src/languages/es.json (2 hunks)
  • apps/router/src/languages/fr.json (2 hunks)
  • apps/router/src/languages/hu.json (2 hunks)
  • apps/router/src/languages/it.json (2 hunks)
  • apps/router/src/languages/ja.json (2 hunks)
  • apps/router/src/languages/ko.json (2 hunks)
  • apps/router/src/languages/pt.json (2 hunks)
  • apps/router/src/languages/ru.json (2 hunks)
  • apps/router/src/languages/zh.json (2 hunks)
Additional comments not posted (23)
apps/router/src/languages/zh.json (2)

33-34: LGTM!

The addition of the "urlLabel" key provides a label for the URL input field, improving clarity for users.


486-495: Looks good!

The new "home" section provides translations for various terms, likely expanding the application's functionality and improving navigation for users.

apps/router/src/languages/ko.json (2)

33-34: LGTM!


486-495: Looks good!

apps/router/src/languages/ja.json (1)

486-495: LGTM!

The added "home" section provides the necessary Japanese translations for the home screen.

apps/router/src/languages/en.json (2)

33-34: LGTM!


181-190: Looks good!

apps/router/src/languages/pt.json (2)

33-34: LGTM!


486-495: Looks good!

apps/router/src/languages/hu.json (2)

33-34: LGTM!

The addition of the "urlLabel" key-value pair looks good.


486-495: LGTM!

The addition of the "home" section with the new key-value pairs looks good.

apps/router/src/languages/ru.json (2)

33-34: LGTM!


486-495: LGTM!

apps/router/src/languages/es.json (2)

33-34: LGTM!


486-495: LGTM!

apps/router/src/languages/it.json (2)

33-34: LGTM!


486-495: LGTM!

apps/router/src/languages/fr.json (2)

33-34: LGTM!


486-495: Looks good!

apps/router/src/languages/ca.json (2)

33-34: LGTM!

The addition of the "urlLabel" key-value pair improves the user interface by providing a clear label for the URL input field.


486-495: LGTM!

The addition of the "home" section with multiple key-value pairs enhances the application's functionality by providing users with more options and clearer navigation within the home interface.

apps/router/src/languages/de.json (2)

33-34: LGTM!


486-495: LGTM!


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 4:04pm

@Kodylow Kodylow merged commit 1ba5f8c into fedimint:master Sep 18, 2024
3 checks passed
@Kodylow Kodylow deleted the add-missing-translations branch September 18, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants