Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(guardian-ui): run consensus in VerifyGuardians before continuing #189

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix(guardian-ui): run consensus in VerifyGuardians before continuing #189

merged 1 commit into from
Sep 7, 2023

Conversation

wbobeirne
Copy link
Collaborator

Closes #169.

What This Does

  • Runs api.runConsensus before continuing from the VerifyGuardians step if you're a solo federation
    • Renders a spinner instead of the verify configs table while this is happening
    • The header and description copy is still kinda wrong since there are no other guardians, but we can refine this later

Screenshots

2023-09-07_12-49-04.mp4

@EthnTuttle EthnTuttle merged commit 2004c7c into master Sep 7, 2023
2 checks passed
@EthnTuttle
Copy link
Collaborator

@dpc can sleep soundly knowing this is fixed. 😅

@wbobeirne wbobeirne deleted the wo/fix-solo-start-consensus branch December 14, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EthnTuttle EthnTuttle EthnTuttle approved these changes

@okjodom okjodom Awaiting requested review from okjodom

@Kodylow Kodylow Awaiting requested review from Kodylow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Solo federation verification step skip puts UI in invalid state
2 participants
@wbobeirne @EthnTuttle