-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitcoin node config + types refactor #174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbobeirne
force-pushed
the
bitcoin-node-config
branch
from
September 11, 2023 18:30
857b746
to
f822616
Compare
Once #193 is merged and this is rebased on master, this PR is good to go. |
wbobeirne
force-pushed
the
bitcoin-node-config
branch
from
September 12, 2023 19:43
f822616
to
bd02167
Compare
EthnTuttle
previously approved these changes
Sep 12, 2023
EthnTuttle
approved these changes
Sep 12, 2023
Kodylow
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built off of #168. Accomplishes the bitcoin node info part of #95.
Marking as draft until fedimint/fedimint#3072 gets made into a new release candidate (v0.1.0-rc4).
What This Does
modules_config_json
rpc to anapi.modulesConfig()
methodapi.modulesConfig()
to the<BitcoinNodeCard />
componentguardian-ui
types to live in a singletypes/
directory due to how frequently types are sharedtypes.ts
is split intotypes/app.ts
andtypes/api.ts
setup/types.ts
intotypes/setup.ts
, updated importsScreenshots