Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitcoin node config + types refactor #174

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Conversation

wbobeirne
Copy link
Collaborator

@wbobeirne wbobeirne commented Sep 1, 2023

Built off of #168. Accomplishes the bitcoin node info part of #95.

Marking as draft until fedimint/fedimint#3072 gets made into a new release candidate (v0.1.0-rc4).

What This Does

  • Hooks up the new modules_config_json rpc to an api.modulesConfig() method
  • Hooks up api.modulesConfig() to the <BitcoinNodeCard /> component
    • Replaced the "Block height" key / value with "Network" since we do not yet have a way to get block height
  • Refactors all guardian-ui types to live in a single types/ directory due to how frequently types are shared
    • Types can be separated into files, e.g. the old types.ts is split into types/app.ts and types/api.ts
    • Moved setup/types.ts into types/setup.ts, updated imports
    • There's likely more consolidation and cleanup that can be done in here, but this is a start

Screenshots

Screenshot 2023-09-01 at 1 52 24 PM

@wbobeirne
Copy link
Collaborator Author

Once #193 is merged and this is rebased on master, this PR is good to go.

@wbobeirne wbobeirne changed the base branch from guardian-ui-figma-spec to master September 11, 2023 18:31
@wbobeirne wbobeirne marked this pull request as ready for review September 12, 2023 19:43
EthnTuttle
EthnTuttle previously approved these changes Sep 12, 2023
apps/guardian-ui/src/components/BitcoinNodeCard.tsx Outdated Show resolved Hide resolved
Copy link
Member

@Kodylow Kodylow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EthnTuttle EthnTuttle merged commit 798277f into master Sep 12, 2023
2 checks passed
@wbobeirne wbobeirne deleted the bitcoin-node-config branch September 12, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants